eskabetxe commented on code in PR #115:
URL:
https://github.com/apache/flink-connector-jdbc/pull/115#discussion_r1572010803
##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/JdbcConnectionOptions.java:
##########
@@ -90,13 +98,31 @@ public JdbcConnectionOptionsBuilder withDriverName(String
driverName) {
return this;
}
+ public JdbcConnectionOptionsBuilder withProperties(Properties
properties) {
Review Comment:
I have mixed feelings about this method...
I understand that it may be practical, but as a user I can expect that the
properties I am passing will override all properties already defined.
as an example:
```
.withProperty("a", "a1")
.withProperties(new properties())
.withProperty("b", "b1")
```
If you saw that (without knowing the implementation), what will you expect.
that a and b should be in the properties, or just b...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
