Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2756
The changes look very good! ð
I'll rebase on top of the recent changes that introduced new
`fold()`/`reduce()` and will also reshuffle/squash the commits a bit to make
the history clearer. I hope that's alright.
I'll also change the name of the `process()` method in
`InternalWindowFunction` back to `apply()` so that we have less changes and the
core of the changes is more obvious. You could change that name in a future PR
if you'd like but it's purely internal. I hope this is also alright.
A word on commit titles: we normally use imperative mood, i.e. "Extend
WindowFunction Metadata" instead of "Extending ..." or "Extends ...".
Initially, this might seem strange but you can think of a commit as being the
command to do something. This is a good read on commit messages:
http://chris.beams.io/posts/git-commit/ I'm not writing so much to discourage
you, I just like good commit messages. And I hope you'll keep up the good work
in the code. ð
Btw, do you also want to do the same changes for `AllWindowedStream`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
