Zakelly commented on code in PR #24678: URL: https://github.com/apache/flink/pull/24678#discussion_r1574232324
########## flink-datastream/src/main/java/org/apache/flink/datastream/impl/operators/ProcessOperator.java: ########## @@ -46,6 +46,12 @@ public ProcessOperator(OneInputStreamProcessFunction<IN, OUT> userFunction) { chainingStrategy = ChainingStrategy.ALWAYS; } + @Override + public boolean isAsyncStateProcessingEnabled() { + // For normal operator (without keyed context) the async state processing is unused. Review Comment: I'd prefer make Datastream V2 directly use the new state v2. We will provide fallback of sync state access in new state framework. So no `toAsync()` method and no `AsyncKeyedStream` should be introduced. This would be more clear to users. Of course, for Datastream V1, we won't touch the original state v1 code path, thus we should introduce new stream if we want to integrate state v2 into DS V1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org