ruanhang1993 commented on code in PR #24564:
URL: https://github.com/apache/flink/pull/24564#discussion_r1576478281
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/MetricStore.java:
##########
@@ -538,19 +557,19 @@ public TaskMetricStore getTaskMetricStore(String taskID) {
@ThreadSafe
public static class TaskMetricStore extends ComponentMetricStore {
private final Map<Integer, SubtaskMetricStore> subtasks;
- private final Map<String, ComponentMetricStore> jmOperators;
+ private final ComponentMetricStore jmOperator;
private TaskMetricStore() {
- this(new ConcurrentHashMap<>(), new ConcurrentHashMap<>(), new
ConcurrentHashMap<>());
+ this(new ConcurrentHashMap<>(), new ConcurrentHashMap<>(), new
ComponentMetricStore());
}
private TaskMetricStore(
Map<String, String> metrics,
Map<Integer, SubtaskMetricStore> subtasks,
- Map<String, ComponentMetricStore> jmOperators) {
+ ComponentMetricStore jmOperators) {
super(metrics);
this.subtasks = checkNotNull(subtasks);
- this.jmOperators = checkNotNull(jmOperators);
+ this.jmOperator = checkNotNull(jmOperators);
Review Comment:
Maybe we could rename the parameter `jmOperators` to `jmOperator` too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
