RocMarshal commented on code in PR #116:
URL:
https://github.com/apache/flink-connector-jdbc/pull/116#discussion_r1580440708
##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/catalog/JdbcCatalog.java:
##########
@@ -29,18 +29,22 @@
import org.apache.flink.table.catalog.exceptions.TableNotExistException;
import java.util.List;
+import java.util.Properties;
+
+import static
org.apache.flink.connector.jdbc.JdbcConnectionOptions.getBriefAuthProperties;
/** Catalogs for relational databases via JDBC. */
@PublicEvolving
public class JdbcCatalog extends AbstractJdbcCatalog {
private final AbstractJdbcCatalog internal;
+ @Deprecated
/**
* Creates a JdbcCatalog.
Review Comment:
Anchor: A
##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/catalog/JdbcCatalog.java:
##########
@@ -77,17 +81,42 @@ public JdbcCatalog(
String pwd,
String baseUrl,
String compatibleMode) {
- super(userClassLoader, catalogName, defaultDatabase, username, pwd,
baseUrl);
+ this(
+ userClassLoader,
+ catalogName,
+ defaultDatabase,
+ baseUrl,
+ compatibleMode,
+ getBriefAuthProperties(username, pwd));
+ }
+
+ /**
+ * Creates a JdbcCatalog.
Review Comment:
@caicancai Thanks for the comment.
I typed it in based on the style like 'Anchor: A'.
Maybe I get the wrong meaning from the comment. Would you mind clarifying
more details ? many thx. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
