[ https://issues.apache.org/jira/browse/FLINK-35215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841547#comment-17841547 ]
Kenneth William Krugler commented on FLINK-35215: ------------------------------------------------- Hi [~fanrui] - thanks for the detailed writeup! Two comments... # I was surprised that Case2 (above) didn't cause a test to fail, until I realized that the previous fix hadn't added a test for failure with 0 serialized bytes. I would recommend adding this, so that your changes don't accidentally re-introduce this bug. # I still am suspicious of the change in performance. The initial fix changes a while(true) loop to one that has a simple comparison, and inside the loop there are calls to methods that are going to be doing significant work. So I really don't see how that change could have caused a significant performance regression, unless I'm missing something. > The performance of serializerKryo and serializerKryoWithoutRegistration are > regressed > ------------------------------------------------------------------------------------- > > Key: FLINK-35215 > URL: https://issues.apache.org/jira/browse/FLINK-35215 > Project: Flink > Issue Type: Bug > Components: API / Type Serialization System > Affects Versions: 1.20.0 > Reporter: Rui Fan > Priority: Blocker > Labels: pull-request-available > Attachments: image-2024-04-25-14-57-55-231.png, > image-2024-04-25-15-00-32-410.png > > > The performance of serializerKryo and serializerKryoWithoutRegistration are > regressed[1][2], I checked recent commits, and found FLINK-34954 changed > related logic. > > [1] > [http://flink-speed.xyz/timeline/#/?exe=1,6,12&ben=serializerKryo&extr=on&quarts=on&equid=off&env=3&revs=50] > [2] > http://flink-speed.xyz/timeline/#/?exe=1,6,12&ben=serializerKryoWithoutRegistration&extr=on&quarts=on&equid=off&env=3&revs=50 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)