davidradl commented on code in PR #24586:
URL: https://github.com/apache/flink/pull/24586#discussion_r1582776111
##########
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/NoFetchingInput.java:
##########
@@ -73,17 +73,14 @@ protected int require(int required) throws KryoException {
position = 0;
int bytesRead = 0;
int count;
- while (true) {
+ while (bytesRead < required) {
count = fill(buffer, bytesRead, required - bytesRead);
Review Comment:
@dannycranmer I saw this linked to in slack - I wondered whether we could
have junits for the required case and higher than required? Maybe as a follow
on issue / pr ? I could code if you were willing to merge for me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
