mbalassi commented on code in PR #819: URL: https://github.com/apache/flink-kubernetes-operator/pull/819#discussion_r1584810870
########## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/metrics/FlinkDeploymentMetrics.java: ########## @@ -165,13 +194,21 @@ private void initNamespaceStatusCounts(String ns) { private void initFlinkVersions(String ns, String flinkVersion) { parentMetricGroup .createResourceNamespaceGroup(configuration, FlinkDeployment.class, ns) - .addGroup(FLINK_VERSION_GROUP_NAME) - .addGroup(flinkVersion) + .addGroup(FLINK_VERSION_GROUP_NAME, flinkVersion) Review Comment: Good question. This is actually semantically different. We can consider a previous behavior a bug, this approach works well with modern metrics systems like Prometheus/Graphana. ########## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/metrics/FlinkDeploymentMetrics.java: ########## @@ -165,13 +194,21 @@ private void initNamespaceStatusCounts(String ns) { private void initFlinkVersions(String ns, String flinkVersion) { parentMetricGroup .createResourceNamespaceGroup(configuration, FlinkDeployment.class, ns) - .addGroup(FLINK_VERSION_GROUP_NAME) - .addGroup(flinkVersion) + .addGroup(FLINK_VERSION_GROUP_NAME, flinkVersion) Review Comment: Good question. This is actually semantically different. We can consider the previous behavior a bug, this approach works well with modern metrics systems like Prometheus/Graphana. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org