jectpro7 commented on code in PR #24756:
URL: https://github.com/apache/flink/pull/24756#discussion_r1590740738
##########
flink-python/pyflink/common/types.py:
##########
@@ -177,7 +177,10 @@ def of_kind(row_kind: RowKind, *args, **kwargs):
return row
def __contains__(self, item):
- return item in self._values
+ if hasattr(self, "_fields"):
+ return item in self._fields
Review Comment:
The enhancement is great. I have one comment, the `_fields` could be a None
by invoking `set_field_names`. So it should return `False` in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
