hackergin commented on code in PR #24750: URL: https://github.com/apache/flink/pull/24750#discussion_r1591725527
########## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/materializedtable/AlterMaterializedTableChangeOperation.java: ########## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.operations.materializedtable; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.table.api.internal.TableResultImpl; +import org.apache.flink.table.api.internal.TableResultInternal; +import org.apache.flink.table.catalog.CatalogMaterializedTable; +import org.apache.flink.table.catalog.ObjectIdentifier; +import org.apache.flink.table.catalog.TableChange; + +import java.util.List; +import java.util.stream.Collectors; + +/** Alter dynamic table with new table definition and table changes represents the modification. */ +@Internal +public class AlterMaterializedTableChangeOperation extends AlterMaterializedTableOperation { + + private final List<TableChange.MaterializedTableChange> tableChanges; + private final CatalogMaterializedTable catalogMaterializedTable; + + public AlterMaterializedTableChangeOperation( + ObjectIdentifier tableIdentifier, + List<TableChange.MaterializedTableChange> tableChanges, Review Comment: The tableChanges here may be a regular tableChange such as SetOption, so I think it we should change type to `List<TableChange>`? ########## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/materializedtable/MaterializedTableManager.java: ########## @@ -0,0 +1,181 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.gateway.service.materializedtable; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.table.api.TableException; +import org.apache.flink.table.catalog.CatalogMaterializedTable; +import org.apache.flink.table.catalog.ObjectIdentifier; +import org.apache.flink.table.catalog.TableChange; +import org.apache.flink.table.data.RowData; +import org.apache.flink.table.gateway.api.operation.OperationHandle; +import org.apache.flink.table.gateway.api.results.ResultSet; +import org.apache.flink.table.gateway.service.operation.OperationExecutor; +import org.apache.flink.table.gateway.service.result.ResultFetcher; +import org.apache.flink.table.gateway.service.utils.SqlExecutionException; +import org.apache.flink.table.operations.materializedtable.AlterMaterializedTableChangeOperation; +import org.apache.flink.table.operations.materializedtable.CreateMaterializedTableOperation; +import org.apache.flink.table.operations.materializedtable.DropMaterializedTableOperation; +import org.apache.flink.table.operations.materializedtable.MaterializedTableOperation; +import org.apache.flink.table.refresh.ContinuousRefreshHandler; +import org.apache.flink.table.refresh.ContinuousRefreshHandlerSerializer; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.ArrayList; +import java.util.List; + +import static org.apache.flink.api.common.RuntimeExecutionMode.STREAMING; +import static org.apache.flink.configuration.DeploymentOptions.TARGET; +import static org.apache.flink.configuration.ExecutionOptions.RUNTIME_MODE; +import static org.apache.flink.configuration.PipelineOptions.NAME; +import static org.apache.flink.streaming.api.environment.ExecutionCheckpointingOptions.CHECKPOINTING_INTERVAL; +import static org.apache.flink.table.api.internal.TableResultInternal.TABLE_RESULT_OK; + +/** Manager is responsible for execute the {@link MaterializedTableOperation}. */ +@Internal +public class MaterializedTableManager { + + private static final Logger LOG = LoggerFactory.getLogger(MaterializedTableManager.class); + + private final OperationExecutor operationExecutor; + + public MaterializedTableManager(OperationExecutor operationExecutor) { + this.operationExecutor = operationExecutor; + } + + public ResultFetcher callMaterializedTableOperation( + OperationHandle handle, MaterializedTableOperation op, String statement) { + if (op instanceof CreateMaterializedTableOperation) { + return callCreateMaterializedTableOperation( + handle, (CreateMaterializedTableOperation) op); + } + throw new SqlExecutionException( + String.format( + "Unsupported Operation %s for materialized table.", op.asSummaryString())); + } + + private ResultFetcher callCreateMaterializedTableOperation( + OperationHandle handle, + CreateMaterializedTableOperation createMaterializedTableOperation) { + CatalogMaterializedTable materializedTable = + createMaterializedTableOperation.getCatalogMaterializedTable(); + if (CatalogMaterializedTable.RefreshMode.CONTINUOUS == materializedTable.getRefreshMode()) { + createMaterializedInContinuousMode(handle, createMaterializedTableOperation); + } else { + throw new SqlExecutionException( + "Only support create materialized table in continuous refresh mode currently."); + } + // Just return ok for unify different refresh job info of continuous and full mode, user + // should get the refresh job info via desc table. + return ResultFetcher.fromTableResult(handle, TABLE_RESULT_OK, false); + } + + private void createMaterializedInContinuousMode( + OperationHandle handle, + CreateMaterializedTableOperation createMaterializedTableOperation) { + // create materialized table first + operationExecutor.callExecutableOperation(handle, createMaterializedTableOperation); + + ObjectIdentifier materializedTableIdentifier = + createMaterializedTableOperation.getTableIdentifier(); + CatalogMaterializedTable catalogMaterializedTable = + createMaterializedTableOperation.getCatalogMaterializedTable(); + + // Set job name, runtime mode, checkpoint interval + // TODO: Set minibatch related optimization options. + Configuration customConfig = new Configuration(); + String jobName = + String.format( + "Materialized_table_%s_continuous_refresh_job", + materializedTableIdentifier.asSerializableString()); + customConfig.set(NAME, jobName); + customConfig.set(RUNTIME_MODE, STREAMING); + customConfig.set(CHECKPOINTING_INTERVAL, catalogMaterializedTable.getFreshness()); + + String insertStatement = + String.format( + "INSERT INTO %s %s", + materializedTableIdentifier, catalogMaterializedTable.getDefinitionQuery()); + try { + // submit flink streaming job + ResultFetcher resultFetcher = + operationExecutor.executeStatement(handle, insertStatement); + + // get execution.target and jobId, currently doesn't support yarn and k8s, so doesn't + // get clusterId + List<RowData> results = fetchAllResults(resultFetcher); + String jobId = results.get(0).getString(0).toString(); + String executeTarget = + operationExecutor.getSessionContext().getSessionConf().get(TARGET); + ContinuousRefreshHandler continuousRefreshHandler = + new ContinuousRefreshHandler(executeTarget, jobId); + byte[] serializedBytes = + ContinuousRefreshHandlerSerializer.INSTANCE.serialize(continuousRefreshHandler); + + // update RefreshHandler to Catalog + CatalogMaterializedTable updatedMaterializedTable = + catalogMaterializedTable.copy( + CatalogMaterializedTable.RefreshStatus.ACTIVATED, + continuousRefreshHandler.asSummaryString(), + serializedBytes); + List<TableChange.MaterializedTableChange> tableChanges = new ArrayList<>(); + tableChanges.add( + TableChange.modifyRefreshStatus( + CatalogMaterializedTable.RefreshStatus.ACTIVATED)); + tableChanges.add( + TableChange.modifyRefreshHandler( + continuousRefreshHandler.asSummaryString(), serializedBytes)); + + AlterMaterializedTableChangeOperation alterDynamicTableChangeOperation = Review Comment: ```suggestion AlterMaterializedTableChangeOperation alterMaterializedTableChangeOperation = ``` ########## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/operation/OperationExecutor.java: ########## @@ -143,11 +145,14 @@ public class OperationExecutor { private final ClusterClientServiceLoader clusterClientServiceLoader; + private final MaterializedTableManager materializedTableManager; + @VisibleForTesting public OperationExecutor(SessionContext context, Configuration executionConfig) { this.sessionContext = context; this.executionConfig = executionConfig; this.clusterClientServiceLoader = new DefaultClusterClientServiceLoader(); + this.materializedTableManager = new MaterializedTableManager(this); Review Comment: It seems that there may be a circular reference here? how about passing it in when calling callMaterializedTable? ########## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/materializedtable/AlterMaterializedTableChangeOperation.java: ########## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.operations.materializedtable; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.table.api.internal.TableResultImpl; +import org.apache.flink.table.api.internal.TableResultInternal; +import org.apache.flink.table.catalog.CatalogMaterializedTable; +import org.apache.flink.table.catalog.ObjectIdentifier; +import org.apache.flink.table.catalog.TableChange; + +import java.util.List; +import java.util.stream.Collectors; + +/** Alter dynamic table with new table definition and table changes represents the modification. */ Review Comment: ```suggestion /** Alter materialized table with new table definition and table changes represents the modification. */ ``` ########## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/materializedtable/MaterializedTableManager.java: ########## @@ -0,0 +1,181 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.gateway.service.materializedtable; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.table.api.TableException; +import org.apache.flink.table.catalog.CatalogMaterializedTable; +import org.apache.flink.table.catalog.ObjectIdentifier; +import org.apache.flink.table.catalog.TableChange; +import org.apache.flink.table.data.RowData; +import org.apache.flink.table.gateway.api.operation.OperationHandle; +import org.apache.flink.table.gateway.api.results.ResultSet; +import org.apache.flink.table.gateway.service.operation.OperationExecutor; +import org.apache.flink.table.gateway.service.result.ResultFetcher; +import org.apache.flink.table.gateway.service.utils.SqlExecutionException; +import org.apache.flink.table.operations.materializedtable.AlterMaterializedTableChangeOperation; +import org.apache.flink.table.operations.materializedtable.CreateMaterializedTableOperation; +import org.apache.flink.table.operations.materializedtable.DropMaterializedTableOperation; +import org.apache.flink.table.operations.materializedtable.MaterializedTableOperation; +import org.apache.flink.table.refresh.ContinuousRefreshHandler; +import org.apache.flink.table.refresh.ContinuousRefreshHandlerSerializer; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.ArrayList; +import java.util.List; + +import static org.apache.flink.api.common.RuntimeExecutionMode.STREAMING; +import static org.apache.flink.configuration.DeploymentOptions.TARGET; +import static org.apache.flink.configuration.ExecutionOptions.RUNTIME_MODE; +import static org.apache.flink.configuration.PipelineOptions.NAME; +import static org.apache.flink.streaming.api.environment.ExecutionCheckpointingOptions.CHECKPOINTING_INTERVAL; +import static org.apache.flink.table.api.internal.TableResultInternal.TABLE_RESULT_OK; + +/** Manager is responsible for execute the {@link MaterializedTableOperation}. */ +@Internal +public class MaterializedTableManager { + + private static final Logger LOG = LoggerFactory.getLogger(MaterializedTableManager.class); + + private final OperationExecutor operationExecutor; + + public MaterializedTableManager(OperationExecutor operationExecutor) { Review Comment: When deserializing RefreshHandler, we may need a classloader. I think we can also pass sessionState to MaterializedTableManager? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
