loserwang1024 commented on code in PR #3255: URL: https://github.com/apache/flink-cdc/pull/3255#discussion_r1593302893
########## flink-cdc-common/src/main/java/org/apache/flink/cdc/common/configuration/ConfigurationUtils.java: ########## @@ -130,7 +130,9 @@ static Duration convertToDuration(Object o) { } static String convertToString(Object o) { - if (o.getClass() == String.class) { + if (o == null) { Review Comment: you are right, just done it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org