1996fanrui commented on PR #24717: URL: https://github.com/apache/flink/pull/24717#issuecomment-2103767266
> Sorry for the confusing sentence. I meant that skipping the `try/catch` block would save a lot of cycles, but your change that causes it to be (correctly) skipped when the count is 0 shouldn't be the common case, so I wouldn't expect that to impact the benchmark results. Thanks for the quick clarification! Yes, my change only adds a simple check `if (count == 0) return;`, and it doesn't impact performance after I run the benchmark. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
