zhuzhurk commented on code in PR #24774:
URL: https://github.com/apache/flink/pull/24774#discussion_r1599414778
##########
flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/ShuffleMaster.java:
##########
@@ -121,4 +122,21 @@ default
CompletableFuture<Collection<PartitionWithMetrics>> getAllPartitionWithM
JobID jobId) {
return CompletableFuture.completedFuture(Collections.emptyList());
}
+
+ /**
+ * Whether the shuffle master supports taking snapshot in batch scenarios,
which will be used
+ * when enable Job Recovery. If it returns true, we will call {@link
#snapshotState} to take
Review Comment:
which will be used when enable Job Recovery
-> if `execution.batch.job-recovery.enabled` is true.
we
-> Flink
##########
flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/ShuffleMasterSnapshotContext.java:
##########
@@ -0,0 +1,25 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.shuffle;
+
+/**
+ * Snapshot context used to create {@link ShuffleMasterSnapshot}, which can
provide necessary
+ * information.
Review Comment:
> which can provide necessary information
Looks redundant to me. I prefer to remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
