superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1599601719
########## docs/data/sql_functions.yml: ########## @@ -350,6 +350,17 @@ string: - sql: LOCATE(string1, string2[, integer]) table: STRING1.locate(STRING2[, INTEGER]) description: Returns the position of the first occurrence of string1 in string2 after position integer. Returns 0 if not found. Returns NULL if any of arguments is NULL. + - sql: URL_DECODE(string) + table: STRING.urlDecode() + description: + Decodes a given string in 'application/x-www-form-urlencoded' format using the UTF-8 encoding scheme, will be null if input is null. + If there is an issue with the decoding process, such as encountering an illegal escape pattern, the function returns the original input value. + If the encoding scheme is not supported, an error will be reported. Review Comment: So should I construct a string encoded with UTF_16 to test? Actually I have no idea of this, could you give me some advice? After all, I noticed that the Calcite has no test on non UTF8. Maybe we just keep it like Calcite does. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org