jeyhunkarimov commented on code in PR #24600:
URL: https://github.com/apache/flink/pull/24600#discussion_r1601116454


##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/utils/DynamicPartitionPruningUtils.java:
##########
@@ -236,6 +238,9 @@ private void setTables(ContextResolvedTable catalogTable) {
                 tables.add(catalogTable);
             } else {
                 for (ContextResolvedTable thisTable : new ArrayList<>(tables)) 
{
+                    if (tables.contains(catalogTable)) {

Review Comment:
   HI @mumuhhh thanks for the ping and your suggestion! I think you are right. 
Now that I look in more detail, in addition to your suggestion, I think we can 
also remove the first  `if` check in the method. I filed the patch: 
https://github.com/apache/flink/pull/24788



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to