lsyldliu commented on code in PR #24767: URL: https://github.com/apache/flink/pull/24767#discussion_r1602508279
########## flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/WorkflowSchedulerFactoryUtil.java: ########## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.factories; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.annotation.PublicEvolving; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.configuration.DelegatingConfiguration; +import org.apache.flink.configuration.ReadableConfig; +import org.apache.flink.table.api.ValidationException; +import org.apache.flink.table.workflow.WorkflowScheduler; +import org.apache.flink.util.StringUtils; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import javax.annotation.Nullable; + +import java.util.Map; +import java.util.stream.Collectors; + +import static org.apache.flink.table.factories.FactoryUtil.PROPERTY_VERSION; +import static org.apache.flink.table.factories.FactoryUtil.WORKFLOW_SCHEDULER_TYPE; +import static org.apache.flink.table.factories.FactoryUtil.stringifyOption; + +/** Utility for working with {@link WorkflowScheduler}. */ +@PublicEvolving +public class WorkflowSchedulerFactoryUtil { + + private static final Logger LOG = LoggerFactory.getLogger(WorkflowSchedulerFactoryUtil.class); + + public static final String WORKFLOW_SCHEDULER_PREFIX = "workflow-scheduler"; + + private WorkflowSchedulerFactoryUtil() { + // no instantiation + } + + /** + * Attempts to discover the appropriate workflow scheduler factory and creates the instance of + * the scheduler. Return null directly if doesn't specify the workflow scheduler in config + * because it is optional for materialized table. + */ + public static @Nullable WorkflowScheduler<?> createWorkflowScheduler( + Configuration configuration, ClassLoader classLoader) { Review Comment: No, MaterializedTableManager will be created when open a session, it will be as a member of SessionState, we can only get the `Configuration` on construct SessionState. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
