ljz2051 commented on code in PR #24768:
URL: https://github.com/apache/flink/pull/24768#discussion_r1604301920
##########
flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStKeyedStateBackend.java:
##########
@@ -147,15 +160,30 @@ public <SV, S extends State> S createState(@Nonnull
StateDescriptor<SV> stateDes
@Override
@Nonnull
public StateExecutor createStateExecutor() {
- // TODO: Make io parallelism configurable
- return new ForStStateExecutor(4, db,
optionsContainer.getWriteOptions());
+ synchronized (lock) {
Review Comment:
You means that `StateExecutor#shutdown `should be invoked in the `close`
method, not the `dispose` method ?
Maybe we need introduce aonther `closed` flag in ForStKeyedStateBackend to
prevent "createStateExecutor after close".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
