liuml07 commented on code in PR #104:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/104#discussion_r1614194871
##########
flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8TestUtils.java:
##########
@@ -0,0 +1,69 @@
+package org.apache.flink.connector.elasticsearch.sink;
+
+import org.apache.http.util.EntityUtils;
+import org.elasticsearch.client.Request;
+import org.elasticsearch.client.Response;
+import org.elasticsearch.client.RestClient;
+import org.testcontainers.utility.DockerImageName;
+
+import java.io.IOException;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+/** Utility class for Elasticsearch8 tests. */
+public class Elasticsearch8TestUtils {
Review Comment:
@reta I'm working on the parameterized tests, which is purely a test code
refactoring:
- Make base test class parameterized with `secure` parameter. As JUnit 5
has limited support for parameterized tests with inheritance, I used the
`ParameterizedTestExtension` introduced in Flink, see [this
doc](https://docs.google.com/document/d/1514Wa_aNB9bJUen4xm5uiuXOooOJTtXqS_Jqk9KJitU/edit#heading=h.jf7lfvm64da4)
- Manage the test container lifecycle instead of using the managed
annotation `@Testcontainers` and `@Container`
- Create and use common methods in the base class that concrete test
classes can be mostly parameter-agnostic
If you prefer we wait for that change, I can push to this branch after I
have a working version. If you agree, I can also create a new PR of the testing
code refactoring for future proof (new tests will be easily covered by secure
clusters).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
