hk-lrzy commented on code in PR #3339:
URL: https://github.com/apache/flink-cdc/pull/3339#discussion_r1614307385
##########
flink-cdc-composer/src/main/java/org/apache/flink/cdc/composer/flink/translator/SchemaOperatorTranslator.java:
##########
@@ -58,12 +59,18 @@ public DataStream<Event> translate(
MetadataApplier metadataApplier,
List<RouteDef> routes) {
switch (schemaChangeBehavior) {
- case EVOLVE:
- return addSchemaOperator(input, parallelism, metadataApplier,
routes);
case IGNORE:
- return dropSchemaChangeEvent(input, parallelism);
+ return dropSchemaChangeEvent(
+ addSchemaOperator(input, parallelism, metadataApplier,
routes, true),
+ parallelism);
+ case TRY_EVOLVE:
+ return addSchemaOperator(input, parallelism, metadataApplier,
routes, true);
+ case EVOLVE:
+ return addSchemaOperator(input, parallelism, metadataApplier,
routes, false);
case EXCEPTION:
- return exceptionOnSchemaChange(input, parallelism);
+ return exceptionOnSchemaChange(
Review Comment:
I agree it, and i also point it in the issue with [JIRA /
https://issues.apache.org/jira/browse/FLINK-35436](https://issues.apache.org/jira/browse/FLINK-35242)
and have another https://github.com/apache/flink-cdc/pull/3355
I think we can merge it into this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
