SamBarker commented on code in PR #90:
URL: https://github.com/apache/flink-benchmarks/pull/90#discussion_r1616369948


##########
pom.xml:
##########
@@ -290,25 +291,31 @@ under the License.
                                                <configuration>
                                                        
<skip>${skipTests}</skip>
                                                        
<classpathScope>test</classpathScope>
-                                                       
<executable>${executableJava}</executable>
+                                                       
<executable>${basedir}/benchmark.sh</executable>

Review Comment:
   The interface with maven is identical so how the Java env is controlled 
stays consistent. The change is in how Jenkins triggers the benchmarks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to