hackergin commented on code in PR #24877: URL: https://github.com/apache/flink/pull/24877#discussion_r1624617251
########## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/service/MaterializedTableStatementITCase.java: ########## @@ -652,6 +654,158 @@ void testAlterMaterializedTableWithoutSavepointDirConfigured() throws Exception "Savepoint directory is not configured, can't stop job with savepoint."); } + @Test + void testAlterMaterializedSuspendAndResumeInFullMode() throws Exception { + createMaterializedTableInFullMode("users_shops", Collections.emptyList()); + + ResolvedCatalogMaterializedTable activeMaterializedTable = + (ResolvedCatalogMaterializedTable) + service.getTable( + sessionHandle, + ObjectIdentifier.of( + fileSystemCatalogName, + TEST_DEFAULT_DATABASE, + "users_shops")); + + assertThat(activeMaterializedTable.getRefreshStatus()) + .isEqualTo(CatalogMaterializedTable.RefreshStatus.ACTIVATED); + + // suspend materialized table + String alterMaterializedTableSuspendDDL = "ALTER MATERIALIZED TABLE users_shops SUSPEND"; + OperationHandle alterMaterializedTableSuspendHandle = + service.executeStatement( + sessionHandle, alterMaterializedTableSuspendDDL, -1, new Configuration()); + + awaitOperationTermination(service, sessionHandle, alterMaterializedTableSuspendHandle); + + ResolvedCatalogMaterializedTable suspendMaterializedTable = + (ResolvedCatalogMaterializedTable) + service.getTable( + sessionHandle, + ObjectIdentifier.of( + fileSystemCatalogName, + TEST_DEFAULT_DATABASE, + "users_shops")); + + assertThat(suspendMaterializedTable.getRefreshStatus()) + .isEqualTo(CatalogMaterializedTable.RefreshStatus.SUSPENDED); + + // verify workflow is suspended + byte[] refreshHandler = suspendMaterializedTable.getSerializedRefreshHandler(); + EmbeddedRefreshHandler suspendRefreshHandler = + EmbeddedRefreshHandlerSerializer.INSTANCE.deserialize( + refreshHandler, getClass().getClassLoader()); + + String workflowName = suspendRefreshHandler.getWorkflowName(); + String workflowGroup = suspendRefreshHandler.getWorkflowGroup(); + EmbeddedQuartzScheduler embeddedWorkflowScheduler = + SQL_GATEWAY_REST_ENDPOINT_EXTENSION + .getSqlGatewayRestEndpoint() + .getQuartzScheduler(); + JobKey jobKey = new JobKey(workflowName, workflowGroup); + Trigger.TriggerState suspendTriggerState = + embeddedWorkflowScheduler + .getQuartzScheduler() + .getTriggerState(new TriggerKey(workflowName, workflowGroup)); + + assertThat(suspendTriggerState).isEqualTo(Trigger.TriggerState.PAUSED); + + // resume materialized table + String alterMaterializedTableResumeDDL = + "ALTER MATERIALIZED TABLE users_shops RESUME WITH ('debezium-json.ignore-parse-errors' = 'true')"; + OperationHandle alterMaterializedTableResumeHandle = + service.executeStatement( + sessionHandle, alterMaterializedTableResumeDDL, -1, new Configuration()); + awaitOperationTermination(service, sessionHandle, alterMaterializedTableResumeHandle); + + ResolvedCatalogMaterializedTable resumedCatalogMaterializedTable = + (ResolvedCatalogMaterializedTable) + service.getTable( + sessionHandle, + ObjectIdentifier.of( + fileSystemCatalogName, + TEST_DEFAULT_DATABASE, + "users_shops")); + + assertThat(resumedCatalogMaterializedTable.getOptions()) + .doesNotContainKey("debezium-json.ignore-parse-errors"); + assertThat(resumedCatalogMaterializedTable.getRefreshStatus()) + .isEqualTo(CatalogMaterializedTable.RefreshStatus.ACTIVATED); + + // verify workflow is resumed + refreshHandler = resumedCatalogMaterializedTable.getSerializedRefreshHandler(); + EmbeddedRefreshHandler resumeRefreshHandler = + EmbeddedRefreshHandlerSerializer.INSTANCE.deserialize( + refreshHandler, getClass().getClassLoader()); + + assertThat(resumeRefreshHandler.getWorkflowName()).isEqualTo(workflowName); + assertThat(resumeRefreshHandler.getWorkflowGroup()).isEqualTo(workflowGroup); + + JobDetail jobDetail = embeddedWorkflowScheduler.getQuartzScheduler().getJobDetail(jobKey); + Trigger.TriggerState resumedTriggerState = + embeddedWorkflowScheduler + .getQuartzScheduler() + .getTriggerState(new TriggerKey(workflowName, workflowGroup)); + assertThat(resumedTriggerState).isEqualTo(Trigger.TriggerState.NORMAL); + + WorkflowInfo workflowInfo = + fromJson((String) jobDetail.getJobDataMap().get(WORKFLOW_INFO), WorkflowInfo.class); + assertThat(workflowInfo.getDynamicOptions()) + .containsEntry("debezium-json.ignore-parse-errors", "true"); + + // delete the workflow + embeddedWorkflowScheduler.deleteScheduleWorkflow(jobKey.getName(), jobKey.getGroup()); + } + + private void createMaterializedTableInFullMode(String tableName, List<Row> data) Review Comment: createAndVerifyCreateMaterializedTableWithData creates a table in continous mode, I made some modifications to support full mode. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org