Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2541
Sorry for asking for another iteration, but here are some comments:
- The other Java code uses the primitive `int` everywhere, rather than
the boxed integer. Let's follow that style.
- I would omit the `public static ExecutionEnvironment
createCustomLocalEnv(Integer parallelism, Configuration config)` variant. The
benefit is very small compared to the `public static ExecutionEnvironment
createLocalEnvironment(Configuration config)` method, but it blows up the API
into too many variants.
- Similarly, I would only have the `public static ExecutionEnvironment
createLocalEnvWithWebUI (int port, Configuration config)` and drop the variant
with the additional `parallelism` parameter.
In general, I think it is good to not have too many method options, but
only those that add significant functionality. For the method that starts the
WebUI, that is the case, for the method with the additional parallelism,
probably not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
