fredia commented on code in PR #24812:
URL: https://github.com/apache/flink/pull/24812#discussion_r1628994002
##########
flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStDBPutRequest.java:
##########
@@ -34,23 +35,33 @@
*/
public class ForStDBPutRequest<K, V> {
- private final K key;
- @Nullable private final V value;
- private final ForStInnerTable<K, V> table;
- private final InternalStateFuture<Void> future;
+ protected final K key;
- private ForStDBPutRequest(
+ @Nullable protected final V value;
+
+ protected final ForStInnerTable<K, V> table;
+
+ protected final InternalStateFuture<Void> future;
+
+ protected final boolean tableIsMap;
+
+ protected ForStDBPutRequest(
K key, V value, ForStInnerTable<K, V> table,
InternalStateFuture<Void> future) {
this.key = key;
this.value = value;
this.table = table;
this.future = future;
+ this.tableIsMap = table instanceof ForStMapState;
}
public boolean valueIsNull() {
return value == null;
}
+ public boolean valueIsMap() {
Review Comment:
I moved the logic of interacting with the db to the `ForStDBPutRequest` and
`ForStDBBunchPutRequest`, `valueIsMap` is deleted now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
