[
https://issues.apache.org/jira/browse/FLINK-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15702158#comment-15702158
]
ASF GitHub Bot commented on FLINK-4669:
---------------------------------------
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2541
> In general, I think it is good to not have too many method options, but
only those that add significant functionality. For the method that starts the
WebUI, that is the case, for the method with the additional parallelism,
probably not.
Function having least parameters is the best style. If have no enough
parameter for user, the function's ability is limited. That's why I prefer
Scala, as it has default parameter value, keep the both.
> The other Java code uses the primitive int everywhere, rather than the
boxed integer. Let's follow that style.
Good idea. In the latest two years, I only wirte scala and give up Java
entirely so that not sensitive to Java.
> scala api createLocalEnvironment() function add default Configuration
> parameter
> -------------------------------------------------------------------------------
>
> Key: FLINK-4669
> URL: https://issues.apache.org/jira/browse/FLINK-4669
> Project: Flink
> Issue Type: Improvement
> Components: Streaming
> Reporter: shijinkui
>
> scala program can't direct use createLocalEnvironment with custom Configure
> object.
> such as I want to start web server in local mode, I will do such as:
> ```
> // set up execution environment
> val conf = new Configuration
> conf.setBoolean(ConfigConstants.LOCAL_START_WEBSERVER, true)
> conf.setInteger(ConfigConstants.JOB_MANAGER_WEB_PORT_KEY,
> ConfigConstants.DEFAULT_JOB_MANAGER_WEB_FRONTEND_PORT)
> val env = new org.apache.flink.streaming.api.scala.StreamExecutionEnvironment(
>
> org.apache.flink.streaming.api.environment.StreamExecutionEnvironment.createLocalEnvironment(2,
> conf)
> )
> ```
> so we need createLocalEnvironment function have a config parameter
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
