vahmed-hamdy commented on code in PR #28:
URL:
https://github.com/apache/flink-connector-gcp-pubsub/pull/28#discussion_r1631292174
##########
flink-connector-gcp-pubsub-e2e-tests/src/test/java/org/apache/flink/connector/gcp/pubsub/sink/util/PubsubHelper.java:
##########
@@ -222,4 +240,33 @@ public Publisher createPublisher(String project, String
topic) throws IOExceptio
.setCredentialsProvider(EmulatorCredentialsProvider.create())
.build();
}
+
+ public void close() {
+ if (topicClient != null) {
+ try {
+ topicClient.shutdown();
+ topicClient.awaitTermination(5, TimeUnit.SECONDS);
Review Comment:
This is only part of a test util class, we are not expecting overrides, but
I would extract it since it is repeated ofc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
