Zakelly commented on code in PR #24904:
URL: https://github.com/apache/flink/pull/24904#discussion_r1632632895
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/Mail.java:
##########
@@ -71,8 +77,13 @@ public Mail(
this.actionExecutor = actionExecutor;
}
+ public MailboxExecutor.MailOptions getMailOptions() {
+ return mailOptions;
+ }
+
public int getPriority() {
- return priority;
+ /** See {@link MailboxExecutor.MailOptions#setInterruptible()}. */
+ return mailOptions.isInterruptible() ? TaskMailbox.MIN_PRIORITY :
priority;
Review Comment:
> That should be fine AFAIK. `MIN_PRIORITY` is used for the top level mails,
that no one should ever `yield` to. `yield()`. Operators, which are the only
ones who should ever call `.yield()`, have priorities always `> MIN_PRIORITY`.
I misread that part. This should be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
