foxus commented on code in PR #142:
URL:
https://github.com/apache/flink-connector-aws/pull/142#discussion_r1632803808
##########
flink-connector-aws/flink-connector-kinesis/pom.xml:
##########
@@ -354,6 +354,12 @@ under the License.
<relocations combine.children="override">
<!-- Do not relocate guava because it is
exposed in the Kinesis API (KinesisProducer#addUserRecord).
Users may be using other affected API's,
so relocations may break user-code -->
+ <relocation>
+
<pattern>org.apache.flink.connector.aws.sink</pattern>
+ <shadedPattern>
+
org.apache.flink.kinesis.shaded.org.apache.flink.connector.aws.sink
+ </shadedPattern>
Review Comment:
@hlteoh37 are you referring to the risk of restoring state that references
FQCN that has now changed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
