ferenc-csaky commented on code in PR #24914:
URL: https://github.com/apache/flink/pull/24914#discussion_r1633282273
##########
flink-connectors/flink-file-sink-common/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/OutputStreamBasedPartFileWriter.java:
##########
@@ -50,7 +50,7 @@ public abstract class OutputStreamBasedPartFileWriter<IN,
BucketID>
@Nullable final Path targetPath;
- private CompactingFileWriter.Type writeType = null;
+ private Type writeType = null;
Review Comment:
It was used in a mixed manner in the file, in some places `Type`, some other
places `CompactingFileWriter.Type`. The class itself is (indirectly)
implementing the `CompactingFileWriter` so IMO `Type` and the variable name is
definitive enough, but TBH I do not have a strong opinion, personally I prefer
shorter code if I have a choice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
