lincoln-lil commented on code in PR #24889:
URL: https://github.com/apache/flink/pull/24889#discussion_r1633334828
##########
docs/layouts/shortcodes/generated/optimizer_config_configuration.html:
##########
@@ -65,6 +71,12 @@
<td><p>Enum</p></td>
<td>When it is `TRY_RESOLVE`, the optimizer tries to resolve the
correctness issue caused by 'Non-Deterministic Updates' (NDU) in a changelog
pipeline. Changelog may contain kinds of message types: Insert (I), Delete (D),
Update_Before (UB), Update_After (UA). There's no NDU problem in an insert only
changelog pipeline. For updates, there are three main NDU problems:<br />1.
Non-deterministic functions, include scalar, table, aggregate functions, both
builtin and custom ones.<br />2. LookupJoin on an evolving source<br />3.
Cdc-source carries metadata fields which are system columns, not belongs to the
entity data itself.<br /><br />For the first step, the optimizer automatically
enables the materialization for No.2(LookupJoin) if needed, and gives the
detailed error message for No.1(Non-deterministic functions) and
No.3(Cdc-source with metadata) which is relatively easier to solve by changing
the SQL.<br />Default value is `IGNORE`, the optimizer does no changes.<br />
<br />Possible values:<ul><li>"TRY_RESOLVE"</li><li>"IGNORE"</li></ul></td>
</tr>
+ <tr>
+
<td><h5>table.optimizer.reuse-optimize-block-with-digest-enabled</h5></td>
Review Comment:
Add 'Batch & Streaming' label.
##########
docs/layouts/shortcodes/generated/optimizer_config_configuration.html:
##########
@@ -125,5 +125,11 @@
<td>Boolean</td>
<td>If set to true, it will merge projects when converting SqlNode
to RelNode.<br />Note: it is not recommended to turn on unless you are aware of
possible side effects, such as causing the output of certain non-deterministic
expressions to not meet expectations(see FLINK-20887).</td>
</tr>
+ <tr>
+ <td><h5>table.optimizer.union-all-as-breakpoint-enabled</h5><br>
<span class="label label-primary">Streaming</span></td>
Review Comment:
Should be Batch & Streaming, see
`BatchCommonSubGraphBasedOptimizer#doOptimize`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
