snuyanzin commented on code in PR #24805: URL: https://github.com/apache/flink/pull/24805#discussion_r1636561747
########## pom.xml: ########## @@ -2371,6 +2371,11 @@ under the License. <exclude>org.apache.flink.util.function.SerializableFunction</exclude> <exclude>org.apache.flink.util.function.SupplierWithException</exclude> <exclude>org.apache.flink.util.function.ThrowingConsumer</exclude> + <!-- Disable check for two two sink methods. --> Review Comment: A question about `DiscardingSink`, `PrintSinkFunction`, `RichSinkFunction` should they also be marked as deprecated? I'm asking since `SinkFunction` is marked as deprecated and those 3 classes implement `SinkFunction` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org