zoltar9264 commented on code in PR #24928:
URL: https://github.com/apache/flink/pull/24928#discussion_r1637586337
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/AcrossCheckpointFileMergingSnapshotManager.java:
##########
@@ -31,12 +33,13 @@ public class AcrossCheckpointFileMergingSnapshotManager
extends FileMergingSnaps
private final PhysicalFilePool filePool;
public AcrossCheckpointFileMergingSnapshotManager(
- String id,
+ JobID jobId,
+ ResourceID tmResourceId,
Review Comment:
Thanks for this suggestion , I moved the generation of id to builder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
