[ 
https://issues.apache.org/jira/browse/FLINK-34918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yubin Li updated FLINK-34918:
-----------------------------
    Summary: Support `ALTER CATALOG COMMENT` syntax  (was: Introduce comment 
for CatalogStore & Support `ALTER CATALOG COMMENT` syntax)

> Support `ALTER CATALOG COMMENT` syntax
> --------------------------------------
>
>                 Key: FLINK-34918
>                 URL: https://issues.apache.org/jira/browse/FLINK-34918
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table SQL / API
>    Affects Versions: 1.20.0
>            Reporter: Yubin Li
>            Assignee: Yubin Li
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: image-2024-06-13-18-01-34-910.png
>
>
> We propose to introduce `getComment()` method in `CatalogDescriptor`, and the 
> reasons are as follows.
> 1. For the sake of design consistency, follow the design of FLIP-295 [1] 
> which introduced `CatalogStore` component, `CatalogDescriptor` includes names 
> and attributes, both of which are used to describe the catalog, and `comment` 
> can be added smoothly.
> 2. Extending the existing class rather than add new method to the existing 
> interface, Especially, the `Catalog` interface, as a core interface, is used 
> by a series of important components such as `CatalogFactory`, 
> `CatalogManager` and `FactoryUtil`, and is implemented by a large number of 
> connectors such as JDBC, Paimon, and Hive. Adding methods to it will greatly 
> increase the implementation complexity, and more importantly, increase the 
> cost of iteration, maintenance, and verification.
>  
> Set comment in the specified catalog. If the comment is already set in the 
> catalog, override the old value with the new one.
> !image-2024-06-13-18-01-34-910.png|width=715,height=523!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to