twalthr commented on code in PR #24929: URL: https://github.com/apache/flink/pull/24929#discussion_r1638286027
########## docs/content/docs/dev/table/sql/create.md: ########## @@ -181,10 +182,16 @@ CREATE TABLE [IF NOT EXISTS] [catalog_name.][db_name.]table_name <like_options>: { - { INCLUDING | EXCLUDING } { ALL | CONSTRAINTS | PARTITIONS } + { INCLUDING | EXCLUDING } { ALL | CONSTRAINTS | DISTRIBUTION | PARTITIONS } | { INCLUDING | EXCLUDING | OVERWRITING } { GENERATED | OPTIONS | WATERMARKS } }[, ...] +<distribution_definition>: Review Comment: nit: rename to `<distribution>`, everything in this snippet is a definition ########## docs/content/docs/dev/table/sql/create.md: ########## @@ -465,6 +480,7 @@ You can control the merging behavior of: * GENERATED - computed columns * METADATA - metadata columns * OPTIONS - connector options that describe connector and format properties +* DISTRIBUTION - distribution definition Review Comment: Can you update the ALTER docs as well? ########## docs/content/docs/dev/table/sql/create.md: ########## @@ -406,6 +413,14 @@ Flink will assume correctness of the primary key by assuming that the columns nu Partition the created table by the specified columns. A directory is created for each partition if this table is used as a filesystem sink. +### `DISTRIBUTED BY / DISTRIBUTED INTO` Review Comment: Copy the text from `SupportsBucketing` including examples. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org