Re: [PR] [FLINK-34918][table] Introduce comment for CatalogStore & Support enhanced `CREATE CATALOG` syntax [flink]

[via GitHub]

liyubin117 commented on code in PR #24934:
URL: https://github.com/apache/flink/pull/24934#discussion_r1639240721


##########
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateCatalog.java:
##########
@@ -45,11 +48,18 @@ public class SqlCreateCatalog extends SqlCreate {
 
     private final SqlNodeList propertyList;
 
+    private final @Nullable SqlNode comment;

Review Comment:
   StringLiteral() returns SqlNode, so we should keep it as `SqlNode`
   
![baf72e629b5f98822abd464ce74da00](https://github.com/apache/flink/assets/7313035/ff49c24e-ccad-42d7-b34b-aa100965af98)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org