snuyanzin commented on code in PR #28: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/28#discussion_r1641831775
########## flink-connector-gcp-pubsub/src/main/java/org/apache/flink/streaming/connectors/gcp/pubsub/emulator/EmulatorCredentialsProvider.java: ########## @@ -20,12 +20,14 @@ import com.google.api.gax.core.CredentialsProvider; import com.google.auth.Credentials; +import java.io.Serializable; + /** * A CredentialsProvider that simply provides the right credentials that are to be used for * connecting to an emulator. NOTE: The Google provided NoCredentials and NoCredentialsProvider do * not behave as expected. See https://github.com/googleapis/gax-java/issues/1148 */ -public final class EmulatorCredentialsProvider implements CredentialsProvider { +public final class EmulatorCredentialsProvider implements CredentialsProvider, Serializable { Review Comment: Looks like we missed it according to Flink contribution guide there should be `serialVersionUID` https://flink.apache.org/how-to-contribute/code-style-and-quality-java/#java-reflection -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
