X-czh commented on code in PR #24618:
URL: https://github.com/apache/flink/pull/24618#discussion_r1644414070
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecSink.java:
##########
@@ -174,6 +180,18 @@ protected Transformation<Object> createSinkTransformation(
inputParallelism));
}
+ Object outputObject = null;
+ if (runtimeProvider instanceof OutputFormatProvider) {
Review Comment:
It's a bit strange that we support `OutputFormatProvider` &
`SinkFunctionProvider` here, but not support `SinkProvider`. Since we've
decided to drop support for deprecated sinks, it suffices to only support
`SinkV2Provider`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
