fapaul commented on code in PR #24998:
URL: https://github.com/apache/flink/pull/24998#discussion_r1661069156
##########
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java:
##########
@@ -337,6 +337,20 @@ void testChainNodeSetParallelism() {
assertThat(vertices.get(0).isParallelismConfigured()).isTrue();
}
+ @Test
+ void testParallelismConfiguredForSinkV2() {
Review Comment:
Isn't this test better placed in `SinkTransformationTranslatorITCaseBase`?
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/translators/SinkTransformationTranslator.java:
##########
@@ -357,7 +357,9 @@ private <I, R> R adjustTransformations(
// In this case, the subTransformation does not contain
any customized
// parallelism value and will therefore inherit the
parallelism value
// from the sinkTransformation.
-
subTransformation.setParallelism(transformation.getParallelism());
+ subTransformation.setParallelism(
+ transformation.getParallelism(),
+ transformation.isParallelismConfigured());
Review Comment:
I haven't followed the runtime development for a while but is
`isParallelismConfigured` also applicable for streaming jobs or only batch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
