fengjiajie commented on PR #25009: URL: https://github.com/apache/flink/pull/25009#issuecomment-2207947762
> thank you @fengjiajie for the contribution. > > Changes looks good to me for preventing Memory leak on Minicluster shutdown . Can you please add tests for the changes ? Thanks for reviewing! I added a test that fails on the version without this change: after using MiniCluster, there's one more ShutdownHook than before. While adding the test, I also verified that if we construct MiniCluster twice on the unmodified version, the ShutdownHook count increases by two. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
