reswqa commented on PR #25097: URL: https://github.com/apache/flink/pull/25097#issuecomment-2233212183
> What do you think add OUTPUT_DIRECTORY_INIT_LOCK setter method with @VisibleForTesting annotation for unit test? I suggest no, that is a very fragile protocol, even though we have architecture test to protect it. Allowing locks to be replaced in production code is dangerous. I'm more inclined to think that the test itself needs to be changed, and we encourage black-box test rather than a test touching such low-level field. If we can't think of a more elegant test case for a while, I'm inclined to leave your PR as it is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
