RocMarshal commented on code in PR #25113:
URL: https://github.com/apache/flink/pull/25113#discussion_r1691120384
##########
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManagerGateway.java:
##########
@@ -88,7 +88,22 @@ CompletableFuture<RegistrationResponse> registerJobMaster(
CompletableFuture<Acknowledge> declareRequiredResources(
JobMasterId jobMasterId,
ResourceRequirements resourceRequirements,
- @RpcTimeout Time timeout);
+ @RpcTimeout Duration timeout);
+
+ /**
+ * @deprecated Use {@link #declareRequiredResources(JobMasterId,
ResourceRequirements,
+ * Duration)}. Declares the absolute resource requirements for a job.
+ * @param jobMasterId id of the JobMaster
+ * @param resourceRequirements resource requirements
+ * @return The confirmation that the requirements have been processed
+ */
+ @Deprecated
+ default CompletableFuture<Acknowledge> declareRequiredResources(
Review Comment:
sounds good~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
