ruanhang1993 commented on code in PR #3490:
URL: https://github.com/apache/flink-cdc/pull/3490#discussion_r1698329050
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/factory/MySqlDataSourceFactory.java:
##########
@@ -243,6 +271,14 @@ private static List<String> getTableList(MySqlSourceConfig
sourceConfig, Selecto
.collect(Collectors.toList());
}
+ private static List<ObjectPath> getChunkKeyColumnTableList(
+ MySqlSourceConfig sourceConfig, Selectors selectors) {
+ return MySqlSchemaUtils.listTables(sourceConfig, null).stream()
Review Comment:
Could we invoke `listTables` once and filter tables in the same list for
each selector?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
