[ 
https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15712592#comment-15712592
 ] 

ASF GitHub Bot commented on FLINK-4565:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2870#discussion_r90496100
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/calls/ScalarOperators.scala
 ---
    @@ -78,6 +78,69 @@ object ScalarOperators {
         }
       }
     
    +  def generateIn(
    +      nullCheck: Boolean,
    +      left: GeneratedExpression,
    +      right: scala.collection.mutable.Buffer[GeneratedExpression],
    +      addReusableCodeCallback: (String, String) => Any)
    +    : GeneratedExpression = {
    +    val resultTerm = newName("result")
    +    val isNull = newName("isNull")
    +
    +    val castNumeric = if (isNumeric(left.resultType) || 
isNumeric(right.head.resultType)) {
    +      (value: String) => s"""new java.math.BigDecimal("" + 
$value).stripTrailingZeros()"""
    --- End diff --
    
    Casting all numeric values to `BigInteger` is quite expensive. Please check 
how numeric casting is done for binary operations, e.g., in 
`generateArithmeticOperator()`.


> Support for SQL IN operator
> ---------------------------
>
>                 Key: FLINK-4565
>                 URL: https://issues.apache.org/jira/browse/FLINK-4565
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Nikolay Vasilishin
>
> It seems that Flink SQL supports the uncorrelated sub-query IN operator. But 
> it should also be available in the Table API and tested.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to