jychen7 commented on code in PR #45: URL: https://github.com/apache/flink-connector-kafka/pull/45#discussion_r1703512310
########## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSourceOptions.java: ########## @@ -36,6 +36,14 @@ public class KafkaSourceOptions { .noDefaultValue() .withDescription("The prefix to use for the Kafka consumers."); + public static final ConfigOption<String> COMPLETE_CLIENT_ID = + ConfigOptions.key("client.id.complete") Review Comment: ```suggestion ConfigOptions.key("client.id") ``` shall we just use the same config as kafka clients? I agree this would NOT be backwards compatible in Flink source, but more align with Kafka clients -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org