[
https://issues.apache.org/jira/browse/FLINK-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15714565#comment-15714565
]
ASF GitHub Bot commented on FLINK-4523:
---------------------------------------
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2916#discussion_r90608161
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxyInterface.java
---
@@ -34,14 +34,16 @@
*
* @param shard the shard to get the iterator
* @param shardIteratorType the iterator type, defining how the shard
is to be iterated
- * (one of: TRIM_HORIZON, LATEST,
AT_SEQUENCE_NUMBER, AFTER_SEQUENCE_NUMBER)
- * @param startingSeqNum sequence number, must be null if
shardIteratorType is TRIM_HORIZON or LATEST
+ * (one of: TRIM_HORIZON, LATEST,
AT_TIMESTAMP, AT_SEQUENCE_NUMBER, AFTER_SEQUENCE_NUMBER)
+ * @param startingMarker is null if shardIteratorType is TRIM_HORIZON
or LATEST,
+ * is as a timestamp if shardIteratorType is
AT_TIMESTAMP,
+ * is as a sequence number if shardIteratorType
is AT_SEQUENCE_NUMBER, AFTER_SEQUENCE_NUMBER
--- End diff --
I would suggest the following changes to the Javadoc here to be more
specific:
is null --> "should be {@code null} if ..."
is as a timestamp --> "should be a {@code Date} value if ..."
is as a sequence number --> "should be a {@code String} representing the
sequence number if ..."
> Allow Kinesis Consumer to start from specific timestamp / Date
> --------------------------------------------------------------
>
> Key: FLINK-4523
> URL: https://issues.apache.org/jira/browse/FLINK-4523
> Project: Flink
> Issue Type: New Feature
> Components: Kinesis Connector
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Wei-Che Wei
> Fix For: 1.2.0
>
>
> We had a Kinesis user requesting this feature on an offline chat.
> To be specific, we let all initial Kinesis shards be iterated starting from
> records at the given timestamp.
> The AWS Java SDK we're using already provides API for this, so we can add
> this functionality with fairly low overhead:
> http://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/services/kinesis/model/GetShardIteratorRequest.html#setTimestamp-java.util.Date-
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
