[ 
https://issues.apache.org/jira/browse/FLINK-5108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15718274#comment-15718274
 ] 

ASF GitHub Bot commented on FLINK-5108:
---------------------------------------

GitHub user Renkai opened a pull request:

    https://github.com/apache/flink/pull/2928

    [FLINK-5108] Remove ClientShutdownHook during job execution

    This patch simply removed ClientShutdownHook  related code. The changes may 
cause `org.apache.flink.yarn.YarnClusterClient#pollingRunner` be brutely stoped 
by processing exit, but it seems ok because the polling runner thread is a 
daemon thread.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Renkai/flink FLINK-5108

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2928.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2928
    
----
commit 7504d57b2e24f70b96c0761102b689bf62653db5
Author: renkai <gaelook...@gmail.com>
Date:   2016-12-03T11:27:39Z

    remove ClientShutdownHook

----


> Remove ClientShutdownHook during job execution
> ----------------------------------------------
>
>                 Key: FLINK-5108
>                 URL: https://issues.apache.org/jira/browse/FLINK-5108
>             Project: Flink
>          Issue Type: Bug
>          Components: YARN Client
>    Affects Versions: 1.2.0, 1.1.3
>            Reporter: Maximilian Michels
>            Assignee: Renkai Ge
>            Priority: Blocker
>             Fix For: 1.2.0
>
>
> The behavior of the Standalone mode is to not react to client interrupts once 
> a job has been deployed. We should change the Yarn client implementation to 
> behave the same. This avoids accidental shutdown of the job, e.g. when the 
> user sends an interrupt via CTRL-C or when the client machine shuts down.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to