xiaochen-zhou commented on code in PR #116:
URL:
https://github.com/apache/flink-connector-kafka/pull/116#discussion_r1756038253
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/enumerator/KafkaSourceEnumStateSerializer.java:
##########
@@ -113,23 +111,26 @@ public KafkaSourceEnumState deserialize(int version,
byte[] serialized) throws I
}
}
- private static Set<TopicPartition> deserializeTopicPartitions(byte[]
serializedTopicPartitions)
+ private static KafkaSourceEnumState deserializeTopicPartitions(byte[]
serializedTopicPartitions,
+
AssignmentStatus status)
Review Comment:
> I'd rename to `deserializeAssignedPartitions` and inline `status`. I don't
see it being used with `UNASSIGNED`.
Thank you for your careful review, I changed to them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
