AHeise commented on code in PR #119:
URL:
https://github.com/apache/flink-connector-kafka/pull/119#discussion_r1767400568
##########
flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/testutils/KafkaUtil.java:
##########
@@ -81,24 +89,19 @@ public static KafkaContainer createKafkaContainer(
} else {
logLevel = "OFF";
}
+ return logLevel;
+ }
- Slf4jLogConsumer logConsumer = new Slf4jLogConsumer(logger);
- if (!StringUtils.isNullOrWhitespaceOnly(loggerPrefix)) {
- logConsumer.withPrefix(loggerPrefix);
- }
- return new KafkaContainer(DockerImageName.parse(dockerImageVersion))
- .withEnv("KAFKA_TRANSACTION_STATE_LOG_REPLICATION_FACTOR", "1")
- .withEnv("KAFKA_TRANSACTION_STATE_LOG_MIN_ISR", "1")
- .withEnv("KAFKA_OFFSETS_TOPIC_REPLICATION_FACTOR", "1")
- .withEnv("KAFKA_CONFLUENT_SUPPORT_METRICS_ENABLE", "false")
- .withEnv("KAFKA_LOG4J_ROOT_LOGLEVEL", logLevel)
- .withEnv("KAFKA_LOG4J_LOGGERS", "state.change.logger=" +
logLevel)
- .withEnv("KAFKA_CONFLUENT_SUPPORT_METRICS_ENABLE", "false")
- .withEnv(
- "KAFKA_TRANSACTION_MAX_TIMEOUT_MS",
- String.valueOf(Duration.ofHours(2).toMillis()))
- .withEnv("KAFKA_LOG4J_TOOLS_ROOT_LOGLEVEL", logLevel)
- .withLogConsumer(logConsumer);
+ public static Logger getLogger(String containerName) {
+ return LoggerFactory.getLogger("container." + containerName);
+ }
+
+ public static Logger getLogger(String type, Class<?> testClass) {
Review Comment:
Good idea. I'll rename to getFlinkLogger then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
