[
https://issues.apache.org/jira/browse/FLINK-5262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15722324#comment-15722324
]
ASF GitHub Bot commented on FLINK-5262:
---------------------------------------
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2945
[FLINK-5262][docs] Introduce Gemfile.lock to avoid dependency range
conflicts
The Gemfile for specifying the Ruby dependencies of our documentation
has fixed dependency versions to avoid incompatible changes with
different versions of the dependencies. However, Ruby's dependency
management allows artifacts to specify ranges for dependencies. This can
be problematic.
For instance, we use 'jekyll' version 2.5.3 which depends on
'jekyll-gist' ~> 1.0 which means 1.0 >= version < 2.0. This may resolve
'jekyll-gist' 1.4.0 which depends on 'octokit' ~> 4.2 which may be 4.2
\>= versions < 5.0. Too bad, 'octokit' starting with 4.4 depends on Ruby
version >= 2.0 which is not available on our build servers.
Since we already use the improved version of Rubys build system called
'bundler', we can mitigate this problem by checking in a Gemfile.lock
file which specifies the exact versions of all dependencies required to
build the docs.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mxm/flink FLINK-5262
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2945.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2945
----
commit b3df07a62317326290d8a3fa1f4d833e0e7b430a
Author: Maximilian Michels <[email protected]>
Date: 2016-12-05T13:32:11Z
[FLINK-5262][docs] Introduce Gemfile.lock to avoid dependency range
conflicts
The Gemfile for specifying the Ruby dependencies of our documentation
has fixed dependency versions to avoid incompatible changes with
different versions of the dependencies. However, Ruby's dependency
management allows artifacts to specify ranges for dependencies. This can
be problematic.
For instance, we use 'jekyll' version 2.5.3 which depends on
'jekyll-gist' ~> 1.0 which means 1.0 >= version < 2.0. This may resolve
'jekyll-gist' 1.4.0 which depends on 'octokit' ~> 4.2 which may be 4.2
>= versions < 5.0. Too bad, 'octokit' starting with 4.4 depends on Ruby
version >= 2.0 which is not available on our build servers.
Since we already use the improved version of Rubys build system called
'bundler', we can mitigate this problem by checking in a Gemfile.lock
file which specifies the exact versions of all dependencies required to
build the docs.
----
> Docs: Introduce a Gemfile.lock to avoid dependency range conflicts
> ------------------------------------------------------------------
>
> Key: FLINK-5262
> URL: https://issues.apache.org/jira/browse/FLINK-5262
> Project: Flink
> Issue Type: Bug
> Components: Documentation
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
>
> The {{Gemfile}} for specifying the Ruby dependencies of our documentation has
> fixed dependency versions to avoid incompatible changes with different
> versions of the dependencies. However, Ruby's dependency management allows
> artifacts to specify ranges for dependencies. This can be problematic.
> For instance, we use 'jekyll' version 2.5.3 which depends on 'jekyll-gist' ~>
> 1.0 which means 1.0 >= version < 2.0. This may resolve 'jekyll-gist' 1.4.0
> which depends on 'octokit' ~> 4.2 which may be 4.2 >= versions < 5.0. Too
> bad, 'octokit' starting with 4.4 depends on Ruby version >= 2.0 which is not
> available on our build servers.
> Since we already use the improved version of Rubys build system called
> 'bundler', we can mitigate this problem by checking in a {{Gemfile.lock}}
> file which specifies the exact versions of all dependencies required to build
> the docs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
