mateczagany commented on code in PR #883:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/883#discussion_r1779656454
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilder.java:
##########
@@ -243,7 +243,8 @@ protected FlinkConfigBuilder applyPodTemplate() throws
IOException {
protected FlinkConfigBuilder applyIngressDomain() {
// Web UI
- if (spec.getIngress() != null) {
+ if (spec.getIngress() != null
Review Comment:
I think we can get rid of `applyIngressDomain()` altogether, this default
configuration is already applied in method `applyFlinkConfiguration()`, where
it's only set if the configuration is not yet set by the user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
