beryllw commented on code in PR #3639:
URL: https://github.com/apache/flink-cdc/pull/3639#discussion_r1797628800
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-paimon/src/main/java/org/apache/flink/cdc/connectors/paimon/sink/v2/PaimonCommitter.java:
##########
@@ -60,28 +62,12 @@ public void
commit(Collection<CommitRequest<MultiTableCommittable>> commitReques
.collect(Collectors.toList());
// All CommitRequest shared the same checkpointId.
long checkpointId = committables.get(0).checkpointId();
- int retriedNumber =
commitRequests.stream().findFirst().get().getNumberOfRetries();
WrappedManifestCommittable wrappedManifestCommittable =
storeMultiCommitter.combine(checkpointId, 1L, committables);
- try {
- if (retriedNumber > 0) {
- storeMultiCommitter.filterAndCommit(
- Collections.singletonList(wrappedManifestCommittable));
- } else {
-
storeMultiCommitter.commit(Collections.singletonList(wrappedManifestCommittable));
- }
- commitRequests.forEach(CommitRequest::signalAlreadyCommitted);
- LOGGER.info(
- String.format(
- "Commit succeeded for %s with %s committable",
- checkpointId, committables.size()));
- } catch (Exception e) {
- commitRequests.forEach(CommitRequest::retryLater);
Review Comment:
Is there a specific purpose for retrying later in this context? @lvyanquan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
